[Q] Identifying Capacitive buttons - Galaxy S 4 Developer Discussion [Developers-Only]

Hi.
I am writing this to ask a small favor. I am working on an Xposed Module called Xposed Additions, and several users of SGS4 and Note3 has issues with Haptic Feedback as their Back and Menu button is not being registered as Capacitive. In the original Android source, these are identified by checking the PolicyFlags for WindowManagerPolicy.FLAG_VIRTUAL, however this flag does not seam to be set for these two devices when using the TouchWiz ROM's. Instead I tried checking the KeyEvent flag for KeyEvent.FLAG_VIRTUAL_HARD_KEY. But this identified all buttons as virtual, including power and volume.
These two devices using the TouchWiz ROM seams to be the only once affected by this. Even TouchWiz on other devices like SGS3 works the way it should, using both ways of checking key type for Capacitive.
Since some devices has pure hardware buttons, I cannot just hard code Haptic Feedback on Back and Menu. I need some other way to identify these two buttons on those devices, but since I don't have one, I cannot play around with the different event flags. Does anyone know how I can go about this?
Also, if someone has some idea as to where this bug might be, I really would like to know. KeyEvent.FLAG_VIRTUAL_HARD_KEY is part of the standard application API, so that one should have worked as expected as it will otherwise break any regular application that depends on it, which means that it has to be a bug.

---

dk_zero-cool said:
Hi.
I am writing this to ask a small favor. I am working on an Xposed Module called Xposed Additions, and several users of SGS4 and Note3 has issues with Haptic Feedback as their Back and Menu button is not being registered as Capacitive. In the original Android source, these are identified by checking the PolicyFlags for WindowManagerPolicy.FLAG_VIRTUAL, however this flag does not seam to be set for these two devices when using the TouchWiz ROM's. Instead I tried checking the KeyEvent flag for KeyEvent.FLAG_VIRTUAL_HARD_KEY. But this identified all buttons as virtual, including power and volume.
These two devices using the TouchWiz ROM seams to be the only once affected by this. Even TouchWiz on other devices like SGS3 works the way it should, using both ways of checking key type for Capacitive.
Since some devices has pure hardware buttons, I cannot just hard code Haptic Feedback on Back and Menu. I need some other way to identify these two buttons on those devices, but since I don't have one, I cannot play around with the different event flags. Does anyone know how I can go about this?
Also, if someone has some idea as to where this bug might be, I really would like to know. KeyEvent.FLAG_VIRTUAL_HARD_KEY is part of the standard application API, so that one should have worked as expected as it will otherwise break any regular application that depends on it, which means that it has to be a bug.
Click to expand...
Click to collapse
What exactly is your end goal? Are you looking to override the haptic feedback intensity or?

---

elesbb said:
What exactly is your end goal? Are you looking to override the haptic feedback intensity or?
Click to expand...
Click to collapse
No, I use XposedBridge to hook PhoneWindowManager.interceptKeyBeforeQueueing(). From here I add custom actions on enabled and configured key codes. at the same time, I make sure to invoke Haptic Feedback the same way done in the original source using the original method.
In the original source and in mine, is looks like this
Code:
if ((policyFlags & FLAG_VIRTUAL) != 0) {
// Perform feedback, but SGS4 and Note3 never get's here
}
Those two devices never get's past the check.

---

dk_zero-cool said:
No, I use XposedBridge to hook PhoneWindowManager.interceptKeyBeforeQueueing(). From here I add custom actions on enabled and configured key codes. at the same time, I make sure to invoke Haptic Feedback the same way done in the original source using the original method.
In the original source and in mine, is looks like this
Code:
if ((policyFlags & FLAG_VIRTUAL) != 0) {
// Perform feedback, but SGS4 and Note3 never get's here
}
Those two devices never get's past the check.
Click to expand...
Click to collapse
So you are saying, the back and menu keys never get detected in the method interceptKeyBeforeQueueing()? I do know that in my own apps running on my S4 i am able to detect what keys are pressed by KeyEvent.KEYCODE_BACK || KeyEvent.KEYCODE_MENU. I don't know if it matters or not if the key is virtual. So in your case it would be something like:
if(keyCode == KeyEvent.KEYCODE_BACK) {
//Do your custom action here, and call the default performHapticFeedback() method

---

elesbb said:
So you are saying, the back and menu keys never get detected in the method interceptKeyBeforeQueueing()? I do know that in my own apps running on my S4 i am able to detect what keys are pressed by KeyEvent.KEYCODE_BACK || KeyEvent.KEYCODE_MENU. I don't know if it matters or not if the key is virtual. So in your case it would be something like:
if(keyCode == KeyEvent.KEYCODE_BACK) {
//Do your custom action here, and call the default performHapticFeedback() method
Click to expand...
Click to collapse
No, they are detected fine. I am just not able to detect that they are Capacitive as they get registered as Hardware Buttons. And using KeyEvent.KEYCODE_BACK will not help, because some devices do have real hardware Back buttons, and those should not get Haptic Feedback on key presses.

---

dk_zero-cool said:
No, they are detected fine. I am just not able to detect that they are Capacitive as they get registered as Hardware Buttons. And using KeyEvent.KEYCODE_BACK will not help, because some devices do have real hardware Back buttons, and those should not get Haptic Feedback on key presses.
Click to expand...
Click to collapse
I finally understand what you are saying lol. I was lost at first but tried to help and figured and i understand what you are having issues with. Let me look at the source (smali) code i have and i will try to help more. You want haptic feedback on only capacitive buttons but not hardware buttons. Correct? I think i got it. Thanks!

---

elesbb said:
I finally understand what you are saying lol. I was lost at first but tried to help and figured and i understand what you are having issues with. Let me look at the source (smali) code i have and i will try to help more. You want haptic feedback on only capacitive buttons but not hardware buttons. Correct? I think i got it. Thanks!
Click to expand...
Click to collapse
That is it yes
This is how it is done originally, but that does not work on the SGS4, because it never get's pased the check.

---

dk_zero-cool said:
That is it yes
This is how it is done originally, but that does not work on the SGS4, because it never get's pased the check.
Click to expand...
Click to collapse
So, i looked at my ROM's (4.2.2) PhoneWindowManager.smali, and its totally different than CMs. Thats prolly why its not working.. there is a method KeyEvent.getFlags() have you tried seeing the result of that? I'm not sure what flags are passed to it but it might hold the necessary info for determining if its a virtual key or not. As of the source code in TouchWiz, there doesn't seem to be an actual condition of determining if the button is virtual or not, this may be due to it being hard coded by the system.
What you could do, is create a special conditional statement for the TouchWiz ROMs. Easiest way to do that would be to have the user tell your xposed module that it is a touchwiz ROM, then check that in the interceptKeyBeforeQueuing method of your xposed module, and if its a back or menu key via KeyEvent.KEYCODE_BACK and KeyEvent.KEYCODE_MENU then perform the custom action and perform the haptic feedback.
---------- Post added at 01:06 AM ---------- Previous post was at 01:00 AM ----------
Just checked KeyEvent flags and there is a KeyEvent.FLAG_VIRTUAL_HARD_KEY so in KeyEvent.getFlags() it might have that flag. So this might work:
interceptKeyBeforeQueuing(KeyEvent event) {
if(event.getFlags() == KeyEvent.FLAG_VIRTUAL_HARD_KEY) {
//This is a virutal key
}

---

elesbb said:
What you could do, is create a special conditional statement for the TouchWiz ROMs. Easiest way to do that would be to have the user tell your xposed module that it is a touchwiz ROM, then check that in the interceptKeyBeforeQueuing method of your xposed module, and if its a back or menu key via KeyEvent.KEYCODE_BACK and KeyEvent.KEYCODE_MENU then perform the custom action and perform the haptic feedback.
Click to expand...
Click to collapse
It seams to be the kernel that has issues. Got confirmation about the same issue on the Play Store SGS4 which does not have TouchWiz. So I would have to identify the Device Board and make special case there.
elesbb said:
Just checked KeyEvent flags and there is a KeyEvent.FLAG_VIRTUAL_HARD_KEY so in KeyEvent.getFlags() it might have that flag. So this might work
Click to expand...
Click to collapse
That I already did try. The FLAG_VIRTUAL_HARD_KEY flag is set for all buttons, including Hardware like Power and Volume. Like I said, there is something really strange going on with those two devices.

---

dk_zero-cool said:
It seams to be the kernel that has issues. Got confirmation about the same issue on the Play Store SGS4 which does not have TouchWiz. So I would have to identify the Device Board and make special case there.
That I already did try. The FLAG_VIRTUAL_HARD_KEY flag is set for all buttons, including Hardware like Power and Volume. Like I said, there is something really strange going on with those two devices.
Click to expand...
Click to collapse
The S4 prolly has the buttons hard coded in the PhoneWIndowManager since Cyanogenmod is cross device compatible they have their own methods in them.
And your surprised all keys hold that flag? Come on this is Samsung we are talking about a lot of things are strange xD lol Anyhow, that might be your best bet, get the device version either the mainboard or some other method, then make a conditional statement based off that and the keycode for which buttons are pressed.
If you need any help let me know! I have the smali code from my 4.2.2 TW ROM so i can easily look at things for ya if you'd like!

---

elesbb said:
And your surprised all keys hold that flag? Come on this is Samsung we are talking about a lot of things are strange xD lol Anyhow, that might be your best bet, get the device version either the mainboard or some other method, then make a conditional statement based off that and the keycode for which buttons are pressed.
Click to expand...
Click to collapse
Not really, I have had my share of Samsung (Still do, SGS3), so I am used to it by now. Especially kernel issues. Samsug properly has the worlds dumbest kernel devs working for them. And it is tipical them to just make a fast hard code instead of fixing the actual solution and make it work as intended. The worst part is that KeyEvent.getFlags() is in the Application API, so this will also break normal apps that use it.
elesbb said:
If you need any help let me know! I have the smali code from my 4.2.2 TW ROM so i can easily look at things for ya if you'd like!
Click to expand...
Click to collapse
You have been a really big help, but there one more thing if you don't mind. Samsung has Sound Feedback? Is this just triggered when doing Haptic Feedback, or is there a specific method used for this in that intercept query method?

---

dk_zero-cool said:
Not really, I have had my share of Samsung (Still do, SGS3), so I am used to it by now. Especially kernel issues. Samsug properly has the worlds dumbest kernel devs working for them. And it is tipical them to just make a fast hard code instead of fixing the actual solution and make it work as intended. The worst part is that KeyEvent.getFlags() is in the Application API, so this will also break normal apps that use it.
You have been a really big help, but there one more thing if you don't mind. Samsung has Sound Feedback? Is this just triggered when doing Haptic Feedback, or is there a specific method used for this in that intercept query method?
Click to expand...
Click to collapse
It might be the same method the haptic feedback is. I'm not sure 100 percent but sadly I have work today. So I will have to check when I get home, which I can't wait for already xD
Sent from my SGH-M919 using Tapatalk

---

@dk_zero-cool have you been able to solve the issue? I saw on Xposed Additions Changelog, but still no haptic feedback on back and menu press...

---

yurividal said:
@dk_zero-cool have you been able to solve the issue? I saw on Xposed Additions Changelog, but still no haptic feedback on back and menu press...
Click to expand...
Click to collapse
Not yet. But I did manage to find a Samsung Released ROM for my SGS3 with the same issue. Have not yet had time to try it, but I will start looking at that some time after Christmas. It does make it easier when I can test it on my own device while working on it.

---

dk_zero-cool said:
Not yet. But I did manage to find a Samsung Released ROM for my SGS3 with the same issue. Have not yet had time to try it, but I will start looking at that some time after Christmas. It does make it easier when I can test it on my own device while working on it.
Click to expand...
Click to collapse
Nice! hope you can figure that out. Keep up the owesome work! Thanks once again, and enjoy your christmas!