Need HELP with EDIFY Code (updater-script, "ifelse" statement) - Almost Solved! - Android Q&A, Help & Troubleshooting

Need HELP with EDIFY Code (updater-script, "ifelse" statement) - Almost Solved!
Original Code
One of our devs gave a simple piece of code for those of us who were tired of waiting for ROMs to take 10 minutes to flash on our LG G2 phones. The change was taking this line in our ROM's updater-script:
Code:
format("ext4", "EMMC", "/dev/block/platform/msm_sdcc.1/by-name/system", "0", "/system");
and change it to:
Code:
delete_recursive("/system");
Issue
This works quite well and a ROM can flash in less than 30 seconds! However, I discovered an odd problem that only happens when I am flashing from my original stock ROM. When I flash a ROM that has the changed code above, the install fails. However, if the line of code remains unchanged, the ROM will flash fine.
POSSIBLE SOLUTION
I don't know what the actual cause is, but I have a possible solution that is not working as expected. My solution is to insert a conditional statement where the updater-script runs a check from the build.prop in the present ROM for something that would identify the ROM as a stock ROM. If the ROM is stock, then the original method is used, if not, then the quick method is used:
Code:
ifelse(
getprop("ro.build.host") == "si-rd10-bx45",
(
format("ext4", "EMMC", "/dev/block/platform/msm_sdcc.1/by-name/system", "0", "/system");
),
(
delete_recursive("/system");
)
);
But this code fails. For some reason, the updater-script is using the second part of the ifelse statement (the result for false)...
I've Tried...
I tried reversing the results for the conditions of true and false, which works, but then the results for true are never produced, which makes the ifelse statement pointless.
I tried file_getprop, but this did not change anything.
I tried changing "delete_recursive" to just "delete", but this did not change anything.
Error Causes?
Is there something about formatting that cannot be made into an ifelse statement?
Is there some known error about ifelse statements?
Is the updater-script checking the build.prop from the ROM being flashed instead of the current ROM?
Is the syntax incorrect?
I would really appreciate any suggestions, help, or advice for this situation. This seems like something that should work... Thank you.

---

It's not the code that wrong
There has to be a mkfs.ext4 </*** or block(s)> or mkfs -t ext4 < /you/get/the/point> in Android or CWM wouldn't be able to make that format. That's the most efficient way and best also. Can use blocks even if you want to. I looked in xbin and saw every format except ntfs and ext4 (why is beyond me lol). Who knows give it a try next time. It's a one (short) line command. Usually either works... I know red hat does... just typed it in on cmd prompt for usage. I'll subscribe. .. reply back please. I'm curious now but don't need to format any testers right now. I just force flash one if it bricks. Only bricked one, but in my defence, the dang power went out during a flash and I DIDNT get the backup bootloader mode unfortunately . It just twitched til the battery died... good luck!
Oh... and "deletion" is destructive and fast... A theory... you damaged the partition "slightly". You may have still shown it there but it was unable to have enough cohesion to hold the file system without corruption. Then the corruption caused failure. Best theory I got.
Drop the delete recursive... it's not necessary and it's the last command. It's confusing your system. You're formatting... that's a total wipe with a purpose. I was too wrapped up looking for command structure IN the phone. Sorry... apps being a pain kinda. Need JSON async commands honestly but they won't work.

---

Your format code is using 5 arguments. Have you confirmed that the update-binary you used supports up to 5 arguments? Not all update-binaries are the same. Otherwise, your script is fine. However, I recommend righting a shell script and having the updater-script copy it over to your /tmp directory and then running it. The shell script will copy your build prop over to your /tmp directory and at which point you can run file_getprop for aparticular string for confirmation. Depending on the results determines what the script will do next. The more shell scripts you implement the more powerful you can make your update.zips .

---

Upgrade From ICS4.0 bootloader to JB4.3 bootloader in an OTA
Hi,
I am having a difficult time with this. How do I customize the update script to update u-boot? Because android only upgrades the boot.img, system.img, and recovery partitions, the automatically generated update package does not support upgrading bootloader. So...would I unzip the update.zip, and then modify the updater_script by implementing the following operations:
# Write u-boot to 1K position.
# u-boot binary should be a no padding uboot!
# For eMMC(iNand) device, needs to unlock boot partition.
ui_print("writting u-boot...");
package_extract_file("files/u-boot-no-padding.bin", "/tmp/u-boot-no-padding.bin");
sysfs_file_write("class/mmc_host/mmc0/mmc0:0001/boot_config", "1");
simple_dd("/tmp/u-boot-no-padding.bin", "/dev/block/mmcblk0", 1024);
sysfs_file_write("class/mmc_host/mmc0/mmc0:0001/boot_config", "8");
show_progress(0.1, 5);
then put the "u-boot-no-padding.bin" in the update package and zip it? Should this script be at the beginning of the updater_script or the end?
Here is the updater_script I've put together. I put the u-boot (bootloader) operations at the end. Would this be correct?
Code:
show_progress(0.1, 0);
format("ext4", "EMMC", "/dev/block/mmcblk0p5");
mount("ext4", "EMMC", "/dev/block/mmcblk0p5", "/system");
package_extract_dir("system", "/system");
symlink("toolbox", "/system/bin/ifconfig");
symlink("toolbox", "/system/bin/hd");
symlink("toolbox", "/system/bin/setprop");
symlink("toolbox", "/system/bin/dmesg");
symlink("toolbox", "/system/bin/load_policy");
symlink("toolbox", "/system/bin/kill");
symlink("toolbox", "/system/bin/reboot");
symlink("toolbox", "/system/bin/top");
symlink("toolbox", "/system/bin/getevent");
symlink("toolbox", "/system/bin/clear");
symlink("toolbox", "/system/bin/setsebool");
symlink("toolbox", "/system/bin/setconsole");
symlink("toolbox", "/system/bin/mount");
symlink("toolbox", "/system/bin/md5");
symlink("toolbox", "/system/bin/wipe");
symlink("toolbox", "/system/bin/newfs_msdos");
symlink("toolbox", "/system/bin/cat");
symlink("toolbox", "/system/bin/renice");
symlink("toolbox", "/system/bin/chmod");
symlink("toolbox", "/system/bin/runcon");
symlink("toolbox", "/system/bin/log");
symlink("toolbox", "/system/bin/start");
symlink("toolbox", "/system/bin/ionice");
symlink("toolbox", "/system/bin/printenv");
symlink("mksh", "/system/bin/sh");
symlink("toolbox", "/system/bin/du");
symlink("toolbox", "/system/bin/nandread");
symlink("toolbox", "/system/bin/mv");
symlink("toolbox", "/system/bin/df");
symlink("toolbox", "/system/bin/dd");
symlink("toolbox", "/system/bin/chcon");
symlink("toolbox", "/system/bin/restorecon");
symlink("toolbox", "/system/bin/cp");
symlink("toolbox", "/system/bin/watchprops");
symlink("toolbox", "/system/bin/rm");
symlink("toolbox", "/system/bin/vmstat");
symlink("toolbox", "/system/bin/ioctl");
symlink("toolbox", "/system/bin/notify");
symlink("toolbox", "/system/bin/lsmod");
symlink("toolbox", "/system/bin/iftop");
symlink("toolbox", "/system/bin/touch");
symlink("toolbox", "/system/bin/chown");
symlink("toolbox", "/system/bin/uptime");
symlink("toolbox", "/system/bin/ln");
symlink("toolbox", "/system/bin/umount");
symlink("toolbox", "/system/bin/ps");
symlink("toolbox", "/system/bin/smd");
symlink("toolbox", "/system/bin/getsebool");
symlink("toolbox", "/system/bin/grep");
symlink("toolbox", "/system/bin/ls");
symlink("toolbox", "/system/bin/date");
symlink("toolbox", "/system/bin/getprop");
symlink("toolbox", "/system/bin/sync");
symlink("toolbox", "/system/bin/sleep");
symlink("toolbox", "/system/bin/insmod");
symlink("toolbox", "/system/bin/lsof");
symlink("toolbox", "/system/bin/mkdir");
symlink("toolbox", "/system/bin/route");
symlink("toolbox", "/system/bin/schedtop");
symlink("toolbox", "/system/bin/id");
symlink("toolbox", "/system/bin/setenforce");
symlink("toolbox", "/system/bin/getenforce");
symlink("toolbox", "/system/bin/sendevent");
symlink("toolbox", "/system/bin/rmdir");
symlink("toolbox", "/system/bin/rmmod");
symlink("toolbox", "/system/bin/netstat");
symlink("toolbox", "/system/bin/cmp");
symlink("toolbox", "/system/bin/stop");
set_perm_recursive(0, 0, 0755, 0644, "/system");
set_perm_recursive(0, 0, 0777, 0777, "/system/etc/init.d");
set_perm_recursive(0, 2000, 0755, 0755, "/system/bin");
set_perm(0, 3003, 06755, "/system/bin/ip");
set_perm(0, 3003, 02750, "/system/bin/netcfg");
set_perm(0, 3004, 02755, "/system/bin/ping");
set_perm(0, 2000, 06750, "/system/bin/run-as");
set_perm_recursive(1002, 1002, 0755, 0440, "/system/etc/bluetooth");
set_perm(0, 0, 0755, "/system/etc/bluetooth");
set_perm(1000, 1000, 0640, "/system/etc/bluetooth/auto_pair_devlist.conf");
set_perm(1002, 1002, 0440, "/system/etc/dbus.conf");
set_perm(1014, 2000, 0550, "/system/etc/dhcpcd/dhcpcd-run-hooks");
set_perm(0, 2000, 0550, "/system/etc/init.goldfish.sh");
set_perm_recursive(0, 0, 0755, 0555, "/system/etc/ppp");
set_perm_recursive(0, 2000, 0755, 0644, "/system/vendor");
set_perm_recursive(0, 2000, 0755, 0644, "/system/vendor/etc");
set_perm(0, 2000, 0755, "/system/vendor/lib");
set_perm_recursive(0, 2000, 0755, 0755, "/system/xbin");
set_perm(0, 0, 06755, "/system/xbin/su");
symlink("/system/xbin/su", "/system/bin/su");
show_progress(0.1, 10);
show_progress(0.2, 0);
package_extract_file("boot.img", "/dev/block/mmcblk0p1");
show_progress(0.2, 10);
ui_print("writting u-boot...");
package_extract_file("files/u-boot-no-padding.bin", "/tmp/u-boot-no-padding.bin");
sysfs_file_write("class/mmc_host/mmc0/mmc0:0001/boot_config", "1");
simple_dd("/tmp/u-boot-no-padding.bin", "/dev/block/mmcblk0", 1024);
sysfs_file_write("class/mmc_host/mmc0/mmc0:0001/boot_config", "8");
show_progress(0.1,, 5);
unmount("/system");
Please help.
Thank you