[MOD][XPOSED] Downloads2SD - Xposed Framework Modules

{
"lightbox_close": "Close",
"lightbox_next": "Next",
"lightbox_previous": "Previous",
"lightbox_error": "The requested content cannot be loaded. Please try again later.",
"lightbox_start_slideshow": "Start slideshow",
"lightbox_stop_slideshow": "Stop slideshow",
"lightbox_full_screen": "Full screen",
"lightbox_thumbnails": "Thumbnails",
"lightbox_download": "Download",
"lightbox_share": "Share",
"lightbox_zoom": "Zoom",
"lightbox_new_window": "New window",
"lightbox_toggle_sidebar": "Toggle sidebar"
}
Redirect several internal SD card locations to the external SD card.
This *only* works if the app uses Environment.getExternalStoragePublicDirectory(String), directly or indirectly, to get the location for the download. At present, it won't redirect app data (stuff in /data/data or /sdcard/Android), I may look into that later.
Apps this works with so far:
* /sdcard/Downloads - Chrome, Firefox (@an0n981, @zouhaier1).
* /sdcard/DCIM - Stock JB 4.2 Camera app.
* /sdcard/Pictures - Screenshot (@JamMasterClay).
[size=+3]Requirements[/size]
* [FRAMEWORK ONLY!] Xposed - ROM modding without modifying APKs
[size=+3]Screenshots[/size]
[size=+3]Caveats[/size]
* Due to weird security measures that make no sense, this won't always work on KitKat.
[size=+3]Downloads[/size]
* Source: https://github.com/egingell/Downloads2SD
[size=+2]Version name: 1.0.8[/size]
Download: com.egingell.downloads2sd_v9_acf08f.apk (267.61 KB)
MD5 checksum: acf08f0476e9d1df8997feee1cd12c32
Changes: Using logcat instead of Xposed to log info (logcat | grep "Downloads2SD").
[size=+2]Version name: 1.0.7[/size]
Download: com.egingell.downloads2sd_v8_dcd0c1.apk (267.42 KB)
MD5 checksum: dcd0c152bc1fbf66e14bf3c2422d101e
Changes: Per @rovo89 and @GermainZ in the Xposed Framework thread, I have switched my hook up slightly. It is unlikely that you, the user, will notice a difference.
[size=+2]Version name: 1.0.2[/size]
Download: com.egingell.downloads2sd_v3_77e3e4.apk (264.94 KB)
MD5 checksum: 77e3e49aa80c9ffe968b18141fb19b61
Changes: Added a check to ensure the new destination is viable (e.g. not an unmounted/removed SD card).
[size=+2]Version name: 1.0.1[/size]
Download: com.egingell.downloads2sd_v2_63f388.apk (264.71 KB)
MD5 checksum: 63f3887beb333dd2ea6dff4a4577dd87
Changes: Graphical bug. Reboots may or may not be required for changes, but it never hurts to just reboot anyway.
[size=+2]Version name: 1.0[/size]
Download: com.egingell.downloads2sd_v1_803aac.apk (264.74 KB)
MD5 checksum: 803aac515c56cecc9fc6a39177f1e167
Changes: Initial commit.

---

Confirmed working with Firefox on Omni 4.4.2

---

Oy. Seems there's a weird bug on my GS4. Works flawlessly on my GS2.
The bug: Repeated listings on the app UI which are confusing to the mod making it not redirect as it should.
Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9

---

Confirmed working with firefox on SM N9005 running x-note 10.0 leonardo edition. Thnx
sent from my rooted SM-N9005 running x-note 10.0 Leonardo Edition

---

Just want to report that everything seems to be work here on 4.4.2. So far I tested taking a picture with stock camera and taking a screenshot with the native Android function.
Thanks! :good:

---

It does not work with downloading a picture in an MMS in Verizon Messages. No surprise there...I absolutely despise that app. Unfortunately since KitKat there's no way to have my messages sync between devices and use a different SMS client. Using the Verizon sync service works better than any 3rd party solution because messages go to Verizon before coming to the phone anyways so often times I'll get a message on my tablet before my phone. 3rd party solutions have to read the SMS database, monitor it for changes, and then forward messages to a separate server. Luckily I hardly ever text people anymore anyways, but I digress.
/rant

---

JamMasterClay said:
It does not work with downloading a picture in an MMS in Verizon Messages. No surprise there...I absolutely despise that app. Unfortunately since KitKat there's no way to have my messages sync between devices and use a different SMS client. Using the Verizon sync service works better than any 3rd party solution because messages go to Verizon before coming to the phone anyways so often times I'll get a message on my tablet before my phone. 3rd party solutions have to read the SMS database, monitor it for changes, and then forward messages to a separate server. Luckily I hardly ever text people anymore anyways, but I digress.
/rant
Click to expand...
Click to collapse
Does the Xposed log show "DOWNLOADS_PICTURES [OLD] => [NEW]", "DOWNLOADS_PICTURES [OLD] => null", or nothing?
Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9

---

egingell said:
Does the Xposed log show "DOWNLOADS_PICTURES [OLD] => [NEW]", "DOWNLOADS_PICTURES [OLD] => null", or nothing?
Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
Click to expand...
Click to collapse
Not a thing, sir.

---

Bummer.
Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9

---

I hope that can be connected to a Bluetooth folder on the external SD card on the next update.

---

JazzBlueWong said:
I hope that can be connected to a Bluetooth folder on the external SD card on the next update.
Click to expand...
Click to collapse
Eventually. I just need to figure out where Android gets the arbitrary folder name from. Hint: It's not the same place as the ones in this mod.
Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9

---

@egingell
When I tap 'Direct Download' here: http://forum.xda-developers.com/devdb/project/dl/?id=4318 using Chrome Beta the browser force closes. I've attached a screenshot of the stack trace occurring with no other modules enabled. I did the same test on both my Note 10.1 and S4 both running OmniROM 4.4.2 with the same behavior on both. Downloading other things works fine, for example long-pressing to download a image.
-Sent from My Galaxy Note 10.1 using Tapatalk

---

JamMasterClay said:
@egingell
When I tap 'Direct Download' here: http://forum.xda-developers.com/devdb/project/dl/?id=4318 using Chrome Beta the browser force closes. I've attached a screenshot of the stack trace occurring with no other modules enabled. I did the same test on both my Note 10.1 and S4 both running OmniROM 4.4.2 with the same behavior on both. Downloading other things works fine, for example long-pressing to download a image.
-Sent from My Galaxy Note 10.1 using Tapatalk
Click to expand...
Click to collapse
Works fine for me, but I'm not using Kit Kat. Even when testing and making other apps crash, I still got my file names and Xposed file names with line numbers in the logcat, so I can't even trap the exception let alone fix it since neither are present in that error log.
Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9

---

egingell said:
Works fine for me, but I'm not using Kit Kat. Even when testing and making other apps crash, I still got my file names and Xposed file names with line numbers in the logcat, so I can't even trap the exception let alone fix it since neither are present in that error log.
Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
Click to expand...
Click to collapse
I hoped it wouldn't be so involved to track down. Xposed log and logcat attached.
EDIT: It's late...forgot to mention Chrome Beta version 33.0.1750.126.

---

JamMasterClay said:
I hoped it wouldn't be so involved to track down. Xposed log and logcat attached.
EDIT: It's late...forgot to mention Chrome Beta version 33.0.1750.126.
Click to expand...
Click to collapse
I'm afraid I still don't see a viable error message, but I will give it a better look in the morning... and I successfully downloaded the file using Chrome Beta.
Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9

---

JamMasterClay said:
@egingell
When I tap 'Direct Download' here: http://forum.xda-developers.com/devdb/project/dl/?id=4318 using Chrome Beta the browser force closes. I've attached a screenshot of the stack trace occurring with no other modules enabled. I did the same test on both my Note 10.1 and S4 both running OmniROM 4.4.2 with the same behavior on both. Downloading other things works fine, for example long-pressing to download a image.
Click to expand...
Click to collapse
JamMasterClay said:
I hoped it wouldn't be so involved to track down. Xposed log and logcat attached.
EDIT: It's late...forgot to mention Chrome Beta version 33.0.1750.126.
Click to expand...
Click to collapse
I managed to get Chrome Beta to crash on my GS2, but for a different reason which I fixed and added an untested fix fr your problem. If you'd like to test it:
[size=+1]Version name: 1.0.3[/size]
Branch: beta
Download: com.egingell.downloads2sd_v4_eb5301.apk (265.48 KB)
MD5 checksum: eb5301465e38f0f7df46b2f24d0dec2c
Changes: Removing Security exception ensuring that the file goes to the "external" storage.

---

egingell said:
I managed to get Chrome Beta to crash on my GS2, but for a different reason which I fixed and added an untested fix fr your problem. If you'd like to test it:
[size=+1]Version name: 1.0.3[/size]
Branch: beta
Download: com.egingell.downloads2sd_v4_eb5301.apk (265.48 KB)
MD5 checksum: eb5301465e38f0f7df46b2f24d0dec2c
Changes: Removing Security exception ensuring that the file goes to the "external" storage.
Click to expand...
Click to collapse
Well, I'm no longer getting a FC. But the download consistently fails before actually starting (i.e. it never gets to showing the download percentage) I've tried multiple times on WiFi (literally sitting next to the router) and on 4G LTE. With the module enabled download fails, without it succeeds. FWIW, in the downloads app where the filename should be is black, and it says unsuccessful below that.
If you feel like continuing to look into this I've attached a new Xposed log and logcat.

---

JamMasterClay said:
Well, I'm no longer getting a FC. But the download consistently fails before actually starting (i.e. it never gets to showing the download percentage) I've tried multiple times on WiFi (literally sitting next to the router) and on 4G LTE. With the module enabled download fails, without it succeeds. FWIW, in the downloads app where the filename should be is black, and it says unsuccessful below that.
If you feel like continuing to look into this I've attached a new Xposed log and logcat.
Click to expand...
Click to collapse
I had a feeling it would do that. I'm bypassing that particular exception, but whatever is triggering it is still there. Does Chrome Stable have the same problem? Doesn't much matter, though. I don't think I can do anything about it.
Is purposely thrown and it doesn't make much sense why, but I digress.
Edit: Those error messages are even less useful.
Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9

---

egingell said:
I had a feeling it would do that. I'm bypassing that particular exception, but whatever is triggering it is still there. Does Chrome Stable have the same problem? Doesn't much matter, though. I don't think I can do anything about it.
Is purposely thrown and it doesn't make much sense why, but I digress.
Edit: Those error messages are even less useful.
Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
Click to expand...
Click to collapse
Yup, same behavior with the non-beta version of Chrome.

---

Just wanted to post that I'm having that same error when trying to download files from Goo.im, Android File Host, and Dev-Host as well. For now I simply changed the Downloads location back to the built-in storage location and everything's working fine. Not a big deal to me, but I just wanted to give you a heads up in case a lot more people on KitKat start using this.